Previous Thread
Next Thread
Print Thread
Rate Thread
#17146 04/20/04 03:04 AM
Joined: Apr 2004
Posts: 6
G
Junior Member
Junior Member
G Offline
Joined: Apr 2004
Posts: 6
hello,

please take a look at the following code and give me some feedback on

1. does it reflect "good programming style"
2. is it "portable"
3. is it "elegant"

i am learning this c language and would love feedback.

so far you guys have been a great help. i want to get up to speed on this programming stuff asap. i got a graphlink for my ti - 83+ graphing calc and wanna get into some assembly with it .. but thats a whole other topic ....

so heres the code ...

Code
 
float celsius_conversion(float fahr);
float kelvin_conversion(float celsius);


float fahr, celsius, kelvin;

int main(void)
{
	

	printf ("\nPlease enter the temperature in Farenheit\n");
	printf ("that you wish to convert to Celsius and Kelvin: ");
	scanf (" %f", &fahr);
	celsius = celsius_conversion(fahr);
	printf("\n%.1f Degrees Farenheit is:\n\n1. %.1f Degrees Celsius\n2. %.1f Kelvin",
	fahr, celsius_conversion(fahr), kelvin_conversion(celsius));
	
	return 0;
}

float celsius_conversion(float fahr)
{   
    
	celsius = (5 * (fahr -32)/9);
	
	return celsius;
	
}

float kelvin_conversion(float celsius)
{
	kelvin = celsius + 273.15;
	
	return kelvin;
	
}		
	 

Sponsored Links
▼ Sponsored Links ▼ ▲ Sponsored Links ▲
#17147 04/27/04 04:04 AM
Joined: Aug 2003
Posts: 68
M
Junior Member
Junior Member
M Offline
Joined: Aug 2003
Posts: 68
yes assembly is a whole other topic. esp for ti-83+. i know a little o' that stuff it is anal. that code looks alright to me. i would say its pretty good programming style. elegance dont ask me about that and i know nothing of porting. but the code itself is functional and its a nice illustration of functions for a beginner.


Link Copied to Clipboard
Member Spotlight
Gremelin
Gremelin
Portland, OR; USA
Posts: 7,204
Joined: February 2002
Forum Statistics
Forums41
Topics33,839
Posts68,797
Members2,177
Most Online73,244
Nov 9th, 2025
Latest Postings
Top Posters
UGN Security 41,392
Gremelin 7,204
SilentRage 1,273
Ice 1,146
pergesu 1,136
Infinite 1,041
jonconley 955
Girlie 908
unreal 860
Top Likes Received
Ghost 2
Girlie 1
unreal 1
Crime 1
Ice 1
Dartur 1
Powered by UBB.threads™ PHP Forum Software 8.0.0